Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PASS IAE: suppression du bouton retour et correction de l'URL du bouton annuler dans le formulaire de demande de prolongation [GEN-1633] #4375

Merged
merged 2 commits into from
Jul 5, 2024
Merged

PASS IAE: suppression du bouton retour et correction de l'URL du bouton annuler dans le formulaire de demande de prolongation [GEN-1633] #4375

merged 2 commits into from
Jul 5, 2024

Conversation

xavfernandez
Copy link
Contributor

🤔 Pourquoi ?

  • Bouton "Retour" en doublon du bouton "Annuler"
  • et clairement quand on annule la demande on s'attend à revenir sur la page du PASS et non celle du tableau de bord.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@xavfernandez
approvals: remove back button on declaration form
e98b948 
and only keep the Reset/"Annuler" button
@xavfernandez xavfernandez requested a review from tonial July 5, 2024 09:42
@xavfernandez xavfernandez self-assigned this Jul 5, 2024
@xavfernandez xavfernandez force-pushed the xfernandez/remove_prolongation_back_button branch from 72c6910 to c217c1c Compare July 5, 2024 09:50
tonial
tonial approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il m'a fallu un moment pour comprendre pourquoi il n'y avait qu'un nouveau snapshot dans le fichier ambr 🙈

@xavfernandez xavfernandez added this pull request to the merge queue Jul 5, 2024
Merged via the queue into master with commit 0b80e09 Jul 5, 2024
11 checks passed
@xavfernandez xavfernandez deleted the xfernandez/remove_prolongation_back_button branch July 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonial tonial tonial approved these changes

Assignees

@xavfernandez xavfernandez

Labels
modifié
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavfernandez @tonial