Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidatures: Permettre aux employeurs de transférer une candidature refusée à une autre SIAE [GEN-221] #4348

Merged
merged 12 commits into from
Aug 1, 2024

Conversation

tonial
Copy link
Contributor

@tonial tonial commented Jul 2, 2024

🤔 Pourquoi ?

Demande de longue date

https://www.notion.so/plateforme-inclusion/En-tant-qu-employeur-je-peux-transf-rer-des-candidats-vers-d-autres-employeurs-d5e1f1ae5145416c9b77931cf7d296c1?pvs=4

J'ai fait attention à découper la PR avec un commit par étape du nouveau parcours pour simplifier la lecture
Les tests sont ajoutés dans le tout dernier commit par contre.

TODO avant de merger :
[ ] attendre le retour des UXs pour le formulaire avec le CV

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Aller sur la page d'une candidature refusée

💻 Captures d'écran

@tonial tonial added the ajouté Ajouté dans le changelog. label Jul 2, 2024
@tonial tonial self-assigned this Jul 2, 2024
@tonial tonial marked this pull request as draft July 2, 2024 08:53
@francoisfreitag francoisfreitag changed the title Candiatures: Permettre aux employeurs de transférer une candidature refusée à une autre SIAE [GEN-221] Candidatures: Permettre aux employeurs de transférer une candidature refusée à une autre SIAE [GEN-221] Jul 2, 2024
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch 4 times, most recently from 7c43e9f to 3483746 Compare July 8, 2024 08:19
@tonial tonial added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch 20 times, most recently from 0f6a5de to 9cf0f33 Compare July 15, 2024 09:38
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch 2 times, most recently from 42081a2 to 9909448 Compare July 26, 2024 09:39
@tonial tonial requested a review from leo-naeka July 29, 2024 12:28
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch from 9909448 to 6cf2580 Compare July 29, 2024 12:44
@tonial tonial requested a review from xavfernandez July 30, 2024 07:56
@tonial
Copy link
Contributor Author

tonial commented Jul 30, 2024

@xavfernandez @leo-naeka un petit tampon ? :D

Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me semble bien avec les souvenirs de ma dernière relecture d'il y a 10 jours 😅

itou/job_applications/models.py Outdated Show resolved Hide resolved
itou/job_applications/models.py Outdated Show resolved Hide resolved
itou/templates/apply/process_internal_transfer.html Outdated Show resolved Hide resolved
itou/templates/apply/process_internal_transfer.html Outdated Show resolved Hide resolved
@tonial tonial requested a review from xavfernandez July 30, 2024 19:20
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch 2 times, most recently from 4eced1a to c8fed4b Compare July 31, 2024 04:16
itou/www/apply/forms.py Show resolved Hide resolved
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch from c8fed4b to 2447d6d Compare July 31, 2024 13:45
@tonial tonial force-pushed the alaurent/job_app_outward_transfert branch from 2447d6d to 2ddc099 Compare July 31, 2024 13:49
@tonial tonial added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 58961dd Aug 1, 2024
11 checks passed
@tonial tonial deleted the alaurent/job_app_outward_transfert branch August 1, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC ajouté Ajouté dans le changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants