-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX/UI : Afficher le nom du candidat en majuscule dans le filtre des PASS IAE et salariés #4347
Conversation
User last name display has been normalized to upper case in 050d7d2.
637f170
to
be58d40
Compare
@@ -55,7 +55,7 @@ def test_multiple_approvals_for_the_same_user(self, client): | |||
response = client.get(url) | |||
|
|||
assertContains(response, "2 résultats") | |||
assertContains(response, approval.user.get_full_name(), count=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum... ça veut dire que l'autre endroit utilise aussi user.get_full_name().title()
, non ?
il faudrait aussi le corriger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non, avant on comptait l’apparition du nom dans le aria-label et le <h3>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AH, et tu as ajouté le h3 ici pour bien vérifier qu'on ne regarde que lui 👍
@@ -55,7 +55,7 @@ def test_multiple_approvals_for_the_same_user(self, client): | |||
response = client.get(url) | |||
|
|||
assertContains(response, "2 résultats") | |||
assertContains(response, approval.user.get_full_name(), count=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AH, et tu as ajouté le h3 ici pour bien vérifier qu'on ne regarde que lui 👍
🤔 Pourquoi ?
050d7d2
🏝️ Comment tester
Utiliser le filtre nom salarié.
💻 Captures d'écran