UX/UI : Afficher le nom du candidat en majuscule dans le filtre des PASS IAE et salariés #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User last name display has been normalized to upper case in 050d7d2.
francoisfreitag
force-pushed
the
ff/capitalize
branch
from
637f170
to
be58d40
Compare
tonial
approved these changes
Jul 2, 2024
tonial
requested changes
Jul 2, 2024
| @@ -55,7 +55,7 @@ def test_multiple_approvals_for_the_same_user(self, client): | |||
| response = client.get(url) | |||
|
|
|||
| assertContains(response, "2 résultats") | |||
| assertContains(response, approval.user.get_full_name(), count=2) | |||
There was a problem hiding this comment.
Hum... ça veut dire que l'autre endroit utilise aussi user.get_full_name().title(), non ?
il faudrait aussi le corriger
There was a problem hiding this comment.
Non, avant on comptait l’apparition du nom dans le aria-label et le <h3>
There was a problem hiding this comment.
AH, et tu as ajouté le h3 ici pour bien vérifier qu'on ne regarde que lui 👍
xavfernandez
approved these changes
Jul 2, 2024
tonial
approved these changes
Jul 2, 2024
| @@ -55,7 +55,7 @@ def test_multiple_approvals_for_the_same_user(self, client): | |||
| response = client.get(url) | |||
|
|
|||
| assertContains(response, "2 résultats") | |||
| assertContains(response, approval.user.get_full_name(), count=2) | |||
There was a problem hiding this comment.
AH, et tu as ajouté le h3 ici pour bien vérifier qu'on ne regarde que lui 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
050d7d2
🏝️ Comment tester
Utiliser le filtre nom salarié.
💻 Captures d'écran