UX/UI : Limiter la sélection rapide à un candidat dans la liste des PASS IAE et salariés [GEN-1687] #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
approved these changes
Jul 2, 2024
| @@ -42,10 +42,10 @@ class ApprovalExpiry(TextChoices): | |||
|
|
|||
|
|
|||
| class ApprovalForm(forms.Form): | |||
| users = forms.MultipleChoiceField( | |||
There was a problem hiding this comment.
le champ s'appelle user sur les PASS, est-ce qu'on veut vraiment renommer ici ?
Ou est-ce qu'il faudrait un jour renommer Approval.user en Approval.job_seeker
There was a problem hiding this comment.
Le renommage de Approval.user en Approval.job_seeker serait à mon avis une bonne chose mais à faire de nuit 😬
There was a problem hiding this comment.
On pourrait renommer Approval.job_seeker à mon avis, ce serait plus clair.
xavfernandez
approved these changes
Jul 2, 2024
| @@ -42,10 +42,10 @@ class ApprovalExpiry(TextChoices): | |||
|
|
|||
|
|
|||
| class ApprovalForm(forms.Form): | |||
| users = forms.MultipleChoiceField( | |||
There was a problem hiding this comment.
Le renommage de Approval.user en Approval.job_seeker serait à mon avis une bonne chose mais à faire de nuit 😬
The select multiple widget is partially broken with the itou-theme. In most places, users actually just want to quickly navigate to a single entry in the list. Simplify the UI and remove bugs by using a ChoiceField instead of a MultipleChoiceField.
francoisfreitag
force-pushed
the
ff/select-pass
branch
from
33aae60
to
005ccbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le thème casse partiellement le MultipleChoiceField, utilisons plutôt le composant de sélection d’un seul élément.
Dans tous les cas, les utilisateurs utilisent le widget pour accéder rapidement à un candidat, et non pour limiter les éléments présents dans la liste à un ensemble de candidats.
🏝️ Comment tester
💻 Captures d'écran