GPS : correctif pour les prescripteurs sans organisation #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
approved these changes
Jun 20, 2024
xavfernandez
approved these changes
Jun 20, 2024
We used the job application process to create beneficiaries for GPS. This was a quick attempt to make the MVP work but it had a downside: a company pk is mandatory. The problem is solo prescribers can't provide one. So they were shown a 500 page. To be nice with solo prescribers, let's use the PE Singleton only when `gps` is present in the job application URL. I know, this piece of code is a real beauty.
celine-m-s
force-pushed
the
celinems/fix-benef-creation
branch
from
de7ed1d
to
78febcf
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nous avons utilisé le parcours de candidature pour la création de bénéficiaires dans GPS. L'objectif était d'aller plus vite en réutilisant l'existant.
Le parcours de candidature a besoin (assez logiquement) d'une
Company.pk. Celle qui était passée était larequest.current_organizationmais cela a posé deux soucis :ApplyBaseView, la Company cherchée l'était parfois avec la PK d'une PrescriberOrganization,Après en avoir discuté en équipe, nous proposons d'utiliser le Singleton Pôle emploi uniquement dans ce cas là et en attendant que GPS devienne pérenne. Il sera alors possible de créer un parcours de création dédié.