Admin: Robustifier le changement d'état des candidatures #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
from
155277a
to
123d244
Compare
tonial
added
the
1-recette-jetable
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
2 times, most recently
from
8f8ea6a
to
8cbde3b
Compare
rsebille
reviewed
Jun 17, 2024
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
5 times, most recently
from
b3e8875
to
da63e24
Compare
tonial
added
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
4 times, most recently
from
84bb5c1
to
f238541
Compare
rsebille
approved these changes
Jun 24, 2024
itou/job_applications/admin.py
Outdated
Comment on lines
290
to
295
| if error.args[0] == "Cannot create an approval without eligibility diagnosis here": | ||
| message = ( | ||
| "Un diagnostic d'éligibilité valide pour ce candidat " | ||
| "et cette SIAE est obligatoire pour pouvoir créer un PASS IAE." | ||
| ) | ||
| elif error.args[0] == "Cannot accept a job application with no hiring start date.": |
There was a problem hiding this comment.
Pour les args[0] == ne faudrait-il pas utiliser une constante pour que ça soit toujours synchroniser avec ce qui est levé dans les AbortTransition ?
Ou alors peut-être remplacer le texte en anglais par le français ? J'ai l'impression que c'est fait comme ça à d'autre endroit, et c'est peut-être la philosophie attendu 🤷.
There was a problem hiding this comment.
Je seconde l'utilisation d'une constante pour garder la synchro.
There was a problem hiding this comment.
Je pars sur la constante parce que le message dans l'admin est un peu adapté pour le support
xavfernandez
approved these changes
Jun 24, 2024
itou/job_applications/admin.py
Outdated
Comment on lines
290
to
295
| if error.args[0] == "Cannot create an approval without eligibility diagnosis here": | ||
| message = ( | ||
| "Un diagnostic d'éligibilité valide pour ce candidat " | ||
| "et cette SIAE est obligatoire pour pouvoir créer un PASS IAE." | ||
| ) | ||
| elif error.args[0] == "Cannot accept a job application with no hiring start date.": |
There was a problem hiding this comment.
Je seconde l'utilisation d'une constante pour garder la synchro.
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
2 times, most recently
from
d6f4cf6
to
f896996
Compare
|
merci pour les relectures |
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
from
f896996
to
7c5333f
Compare
tonial
force-pushed
the
alaurent/job_app_admin_actions
branch
from
7c5333f
to
d62f327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Force le fait de passer par les transitions d'état et l'envoi des emails correspondants.
Impact pour le support :
TODO:
💻 Captures d'écran
🚨 À vérifier
🏝️ Comment tester