Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import IAE : Utiliser les données issues de l'équipe RIAE de l'ASP plutôt que celle de la DGEFP #4048

Merged
merged 2 commits into from
May 22, 2024

Conversation

rsebille
Copy link
Contributor

@rsebille rsebille commented May 7, 2024

🤔 Pourquoi ?

La DGEFP va arrêter de nous fournir ces données car l'ASP nous les envois.

🍰 Comment ?

Ça me plait moyen mais je n'ai pas trouvé plus "simple" que l'extension personnalisée, et ça fait pas si dégueulasse que ça.

🏝️ Comment tester

  • Copier l'archive .tar.gz du bucket de l'équipe RIAE de l'ASP dans un dossier asp_riae_shared_bucket à la racine du projet
  • Configurer ASP_RIAE_UNZIP_PASSWORD
  • Lancer ./scripts/import-iae.sh en local ☕

shutil.register_unpack_format("gz", [".gz"], gunzip)
shutil.register_unpack_format("7zip", [".7z"], unpack_7zarchive)
shutil.register_unpack_format("zip-riae", [".riae"], unpack_riae_zip_aes_encrypted)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arnaque !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si les algos ne changent plus, on peut ouvrir le ZipFile conteneur puis chaque fichier individuellement directement avec pyzipper, plutôt que d’utiliser shutil, non ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est sûrement l'étape de fin oui, je suis pas partis sur ça car ça veux dire descendre ce qui est dans import-iae.sh dans les management commands et donc toucher des trucs à plein d'endroits car le code s'attend à un truc particulier, donc j'attendais plutôt d'avoir extrait populate_metabase_fluxiae du C1 pour faire ça.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N’hésites pas à le noter, car j’oublierai probablement 🙊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peut-être ajouter un TODO ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'en ai pas mis car c'est pas quelque chose qui peux être fait directement la prochaine fois que quelqu'un passe sur ces lignes, et que d'ici là des choses auront peut-être encore changée donc le TODO pourrais être "faux".

@francoisfreitag
Copy link
Contributor

J’ai essayé de regarder si on ne pouvait pas s’en sortir avec un subprocess.run(), mais a priori il faudrait avoir 7z sur clever, ce qui demande de la configuration et est encore moins visible que dans les requirements... Tant pis.

Copy link

socket-security bot commented May 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, network 0 334 kB alexmojaki, dsagal
pypi/[email protected] environment, eval, filesystem, network, unsafe 0 2.1 MB leonard
pypi/[email protected] environment, filesystem, shell 0 56.2 kB FFY00, gaborbernat, henryiii, ...1 more
pypi/[email protected] filesystem 0 44.9 kB asottile
pypi/[email protected] environment, eval, filesystem, network, shell 0 922 kB
pypi/[email protected] environment 0 116 kB tartley, wiggin15
pypi/[email protected] None 0 364 kB bitwiseman
pypi/[email protected] eval, filesystem 0 116 kB micheles
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 1.65 MB vsajip
pypi/[email protected] environment, eval, network, shell 0 1.06 MB CodenameTim, aaugustin, dcramer, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 1.13 MB trbs
pypi/[email protected] eval, filesystem 0 172 kB christopher.pickering
pypi/[email protected] eval, filesystem 0 48 kB treyhunner, xuhdev
pypi/[email protected] environment, eval, filesystem, network, shell 0 348 kB hpk, nicoddemus, ronny
pypi/[email protected] environment, eval, filesystem, network 0 7.7 MB 15r10nk, alexmojaki
pypi/[email protected] environment, filesystem 0 648 kB dnerdy, xelnor
pypi/[email protected] environment, eval, unsafe 0 8.12 MB curella.org, joke2k
pypi/[email protected] unsafe 0 49.3 kB benediktschmitt
pypi/[email protected] unsafe 0 151 kB bblommers, spulec
pypi/[email protected] None 0 43.2 kB christopher.pickering
pypi/[email protected] None 0 41.7 kB christopher.pickering
pypi/[email protected] environment, filesystem 0 372 kB asottile, ckuehl
pypi/[email protected] filesystem 0 15.4 kB hpk, ronny
pypi/[email protected] environment, filesystem 0 75.1 kB gnebehay, gotcha
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 9.3 MB bgranger, fperez, ivanov, ...2 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.17 MB David.Halter
pypi/[email protected] eval, filesystem, network, shell 0 530 kB Richard.Bronosky, bitwiseman
pypi/[email protected] filesystem 0 104 kB dpranke
pypi/[email protected] network 0 24.8 kB Sylvain.Corlay, fperez, martinRenou, ...1 more
pypi/[email protected] environment, filesystem, network, shell 0 151 kB evkalinin
pypi/[email protected] environment, eval, filesystem, shell 0 2.34 MB brettcannon, dstufft, pf_moore, ...1 more
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 860 kB David.Halter
pypi/[email protected] eval, filesystem, shell 0 107 kB AdamChainz
pypi/[email protected] filesystem 0 186 kB cpburnz
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 637 kB Red_M, jquast, luyer, ...2 more
pypi/[email protected] environment, eval, filesystem, shell 0 559 kB jazzband, nvie
pypi/[email protected] environment, shell 0 108 kB Julian, Ofekmeister, ronny
pypi/[email protected] environment, filesystem, network, shell 0 208 kB The_Compiler, flub, goodboy, ...3 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 345 kB asottile
pypi/[email protected] environment, eval, filesystem, network, shell 0 1.78 MB jonathan.slenders
pypi/[email protected] environment, filesystem 0 144 kB Red_M, luyer, takowl
pypi/[email protected] environment, eval, filesystem 0 72.5 kB 15r10nk, alexmojaki
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 42.7 MB Anteru, gbrandl, mitsuhiko
pypi/[email protected] environment, filesystem, shell 0 59.6 kB pradyunsg, takowl
pypi/[email protected] environment, filesystem, network, shell 0 345 kB AdamChainz, andreaspelme, bluetech, ...2 more
pypi/[email protected] filesystem 0 123 kB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] None 0 50.4 kB AdamChainz
pypi/[email protected] None 0 63.4 kB nicoddemus, ronny
pypi/[email protected] environment, eval, filesystem, network 0 337 kB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 5.12 MB The_Compiler, anatoly, flub, ...4 more
pypi/[email protected] environment, eval, filesystem, network, shell 0 234 kB danifus
pypi/[email protected] environment, eval, filesystem, network 0 6.73 MB RedisLabs, cisk
pypi/[email protected] environment, filesystem 0 153 kB
pypi/[email protected] eval, filesystem, unsafe 0 3.44 MB mrabarnett
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 438 kB Lukasa, graffatcolmingov, nateprewitt
pypi/[email protected] None 0 6.38 MB Julian
pypi/[email protected] environment, filesystem, network 0 739 kB aws
pypi/[email protected] environment, filesystem, network, shell, unsafe 0 1.26 MB getsentry, mitsuhiko
pypi/[email protected] environment, filesystem 0 134 kB gutworth
pypi/[email protected] eval, filesystem 0 48.1 kB
pypi/[email protected] filesystem, shell 0 360 kB aalbrecht
pypi/[email protected] environment, eval, filesystem, unsafe 0 301 kB iurisilvio, jazzband, kennethreitz, ...1 more
pypi/[email protected] eval, unsafe 0 197 kB jd, sileht
pypi/[email protected] environment, eval, filesystem, network, shell 0 568 kB casper.dcl, tqdm
pypi/[email protected] environment, eval, filesystem, shell, unsafe 0 352 kB JelleZijlstra, guido, hauntsaninja, ...3 more
pypi/[email protected] filesystem, shell, unsafe 0 960 kB avian, bbangert
pypi/[email protected] environment, eval, network 0 1.14 MB brettcannon, graffatcolmingov, jcgregorio, ...1 more
pypi/[email protected] environment, eval, filesystem, network, unsafe 0 1.18 MB SethMichaelLarson, shazow
pypi/[email protected] network 0 39.4 kB SimonSapin, gsnedders
pypi/[email protected] filesystem 0 410 kB carthorse-python-excel, chrisw, sjmachin
pypi/[email protected] None 0 62.6 kB dbaty, polyconseil, sebdiem, ...1 more
pypi/[email protected] environment 0 187 kB xelnor
pypi/[email protected] filesystem 0 37.7 kB Allan.Lei

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

scripts/import-iae.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça me chagrine un peu d'utiliser une lib pas mise à jour depuis quasi 2 ans :'(

@rsebille
Copy link
Contributor Author

@xavfernandez La seul alternative que j'ai trouvé c'est d'utiliser 7z mais c'est pas installer par défaut sur les machines Clever, donc ça ne me semblait pas rentable de partir dans des trucs un poils plus (trop ?) compliqués alors que le cas d'usage est très limité.

@rsebille rsebille added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit 0610f47 May 22, 2024
11 checks passed
@rsebille rsebille deleted the rsebille/use-riae-data branch May 22, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants