Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-132] Disparition automatique des toasts après 6 secondes #4025

Merged
merged 1 commit into from
May 6, 2024

Conversation

leo-naeka
Copy link
Contributor

🤔 Pourquoi ?

https://www.notion.so/plateforme-inclusion/Disparition-automatique-des-toasts-apr-s-un-certain-d-lais-e327e924783348b0a7d26a088fce6dd6?pvs=4

🍰 Comment ?

  • Suppression de l'affichage sticky par défaut
  • Initialisation des toasts + affichage au chargement de la page

💻 Captures d'écran

Enregistrement.de.l.ecran.2024-05-03.a.18.38.13.mp4

Copy link

@leo-naeka leo-naeka added this pull request to the merge queue May 6, 2024
Merged via the queue into master with commit d7d4bb0 May 6, 2024
12 checks passed
@leo-naeka leo-naeka deleted the leo/hide-toasts-after-6s branch May 6, 2024 07:54
@@ -216,6 +216,10 @@
$(this).toast("show");
});
});

document.querySelectorAll(".toast-container .toast").forEach(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai l'impression que c'était le but du code JS juste au dessus qui a été cassé par https://github.com/gip-inclusion/les-emplois/pull/3102/files#diff-6a8880b38d2ee7e55beabe7d64088997af158b5afacc35bdb476513a5b343e85L58-R58 .
L'avantage de la version précédente était qu'elle gérait également (a priori) les toasts rajoutés en htmx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants