Fiches salarié : Prendre en compte les suspensions dans la détection des notifications ratées #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
xavfernandez
approved these changes
Apr 4, 2024
rsebille
force-pushed
the
rsebille/sanitize-employee-records-missed-notifications-simplification
branch
from
d12aeb0
to
b8dd05b
Compare
2 tasks
rsebille
force-pushed
the
rsebille/sanitize-employee-records-missed-notifications-simplification
branch
from
b8dd05b
to
3751d59
Compare
xavfernandez
approved these changes
May 2, 2024
Since 1c4c323 we can use `Approval.updated_at` to get the last time the approval has changed, this will cover prolongations and suspensions. It's possible we create false positive notifications but in almost all cases an approval modification is on its start or end date.
rsebille
force-pushed
the
rsebille/sanitize-employee-records-missed-notifications-simplification
branch
from
3751d59
to
0bf6557
Compare
rsebille
deleted the
rsebille/sanitize-employee-records-missed-notifications-simplification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pourquoi ?
Simplification et amélioration suite à #3821.
J'ai ajouté la limite car il y a un peu de backlog :
À vérifier