send discord notification on send sms fail

gip-inclusion · Sep 11, 2024 · de4efd1 · de4efd1
1 parent 2beef52
commit de4efd1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/back/src/domains/core/notifications/adapters/BrevoNotificationGateway.manual.test.ts b/back/src/domains/core/notifications/adapters/BrevoNotificationGateway.manual.test.ts
@@ -63,8 +63,7 @@ describe("BrevoNotificationGateway manual", () => {
     async () => {
       const phones = [];
 
-      for (let i = 0; i < times; i++)
-        phones.push("VALID_INTERNATIONAL_FRENCH_MOBILE_PHONE_NUMBER"); // Like +33611223344
+      for (let i = 0; i < times; i++) phones.push("+33604028652"); // Like +33611223344
       await Promise.all(
         phones.map((phone, index) =>
           notificationGateway.sendSms({

diff --git a/back/src/domains/core/notifications/adapters/BrevoNotificationGateway.ts b/back/src/domains/core/notifications/adapters/BrevoNotificationGateway.ts
@@ -11,6 +11,7 @@ import {
   NotificationId,
   type TemplatedEmail,
   type TemplatedSms,
+  castError,
   emailTemplatesByName,
   errors,
   smsTemplatesByName,
@@ -23,6 +24,7 @@ import {
   counterSendTransactEmailTotal,
 } from "../../../../utils/counters";
 import { createLogger } from "../../../../utils/logger";
+import { notifyObjectDiscord } from "../../../../utils/notifyDiscord";
 import { NotificationGateway } from "../ports/NotificationGateway";
 import { BrevoNotificationGatewayRoutes } from "./BrevoNotificationGateway.routes";
 import {
@@ -165,11 +167,16 @@ export class BrevoNotificationGateway implements NotificationGateway {
         }),
       )
       .catch((error) => {
+        const castedError = castError(error);
         logger.error({
           notificationId,
-          error,
+          error: castedError,
           message: "sendTransactSmsError",
         });
+        notifyObjectDiscord({
+          _message: "Error send sms",
+          ...castedError,
+        });
         throw error;
       });
   }