fix establishment tutor can get conventions

back/src/domains/convention/use-cases/GetConvention.unit.test.ts

@@ -24,6 +24,17 @@ describe("Get Convention", () => {
     .withValidatorEmails(["[email protected]"])
     .build();
   const convention = new ConventionDtoBuilder().withAgencyId(agency.id).build();
+  const conventionWithEstablishmentTutor = new ConventionDtoBuilder()
+    .withAgencyId(agency.id)
+    .withEstablishmentTutor({
+      email: "[email protected]",
+      firstName: "John",
+      lastName: "Doe",
+      role: "establishment-tutor",
+      phone: "+33602010203",
+      job: "Job",
+    })
+    .build();
   let getConvention: GetConvention;
   let uow: InMemoryUnitOfWork;
 
@@ -257,6 +268,42 @@ describe("Get Convention", () => {
         });
       });
 
+      it("that establishment tutor is also the inclusion connected user", async () => {
+        uow.conventionRepository.setConventions([
+          conventionWithEstablishmentTutor,
+        ]);
+        const user: InclusionConnectedUser = {
+          id: "my-tutor-user-id",
+          email: conventionWithEstablishmentTutor.establishmentTutor.email,
+          firstName: "John",
+          lastName: "Doe",
+          agencyRights: [],
+          dashboards: { agencies: {}, establishments: {} },
+          externalId: "john-tutor-external-id",
+          createdAt: new Date().toISOString(),
+        };
+        uow.userRepository.setInclusionConnectedUsers([user]);
+
+        const jwtPayload: InclusionConnectDomainJwtPayload = {
+          userId: user.id,
+        };
+
+        const fetchedConvention = await getConvention.execute(
+          { conventionId: conventionWithEstablishmentTutor.id },
+          jwtPayload,
+        );
+
+        expectToEqual(fetchedConvention, {
+          ...conventionWithEstablishmentTutor,
+          agencyName: agency.name,
+          agencyDepartment: agency.address.departmentCode,
+          agencyKind: agency.kind,
+          agencySiret: agency.agencySiret,
+          agencyCounsellorEmails: agency.counsellorEmails,
+          agencyValidatorEmails: agency.validatorEmails,
+        });
+      });
+
       it("the user is backofficeAdmin", async () => {
         const backofficeAdminUser = new InclusionConnectedUserBuilder()
           .withIsAdmin(true)

shared/src/inclusionConnect/inclusionConnect.dto.ts

@@ -4,9 +4,9 @@ import {
   InclusionConnectedUser,
   User,
 } from "../inclusionConnectedAllowed/inclusionConnectedAllowed.dto";
-import { SignatoryRole } from "../role/role.dto";
+import { EstablishmentRole } from "../role/role.dto";
 import { allowedStartInclusionConnectLoginPages } from "../routes/routes";
-import { ExcludeFromExisting, ExtractFromExisting } from "../utils";
+import { ExcludeFromExisting } from "../utils";
 
 export type AuthenticateWithInclusionCodeConnectParams = WithSourcePage & {
   code: string;
@@ -26,7 +26,7 @@ export type AuthenticatedUserQueryParams = {
 
 type InclusionConnectConventionManageAllowedRole =
   | ExcludeFromExisting<AgencyRole, "toReview">
-  | ExtractFromExisting<SignatoryRole, "establishment-representative">
+  | EstablishmentRole
   | "backOffice";
 
 export const getIcUserRoleForAccessingConvention = (
@@ -37,6 +37,8 @@ export const getIcUserRoleForAccessingConvention = (
   if (user.isBackofficeAdmin) roles.push("backOffice");
   if (convention.signatories.establishmentRepresentative.email === user.email)
     roles.push("establishment-representative");
+  if (convention.establishmentTutor.email === user.email)
+    roles.push("establishment-tutor");
   const agencyRight = user.agencyRights.find(
     (agencyRight) => agencyRight.agency.id === convention.agencyId,
   );