throw error when broadcast request already in process

gip-inclusion · Nov 5, 2024 · 3ac9146 · 3ac9146
1 parent ab4d01b
commit 3ac9146
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 2 deletions.
diff --git a/back/src/domains/convention/use-cases/broadcast/BroadcastConventionAgain.ts b/back/src/domains/convention/use-cases/broadcast/BroadcastConventionAgain.ts
@@ -3,6 +3,7 @@ import {
   formatDuration,
   intervalToDuration,
   isBefore,
+  subMinutes,
 } from "date-fns";
 import fr from "date-fns/locale/fr";
 import {
@@ -56,6 +57,17 @@ export const makeBroadcastConventionAgain = createTransactionalUseCase<
       now: deps.timeGateway.now(),
     });
 
+    const lastUnpublishedBroadcastRequest =
+      await uow.outboxRepository.getLastUnpublishedConventionBroadcastRequestedEventByConventionId(
+        conventionId,
+      );
+    if (
+      lastUnpublishedBroadcastRequest &&
+      new Date(lastUnpublishedBroadcastRequest?.occurredAt) <=
+        subMinutes(deps.timeGateway.now(), 30)
+    )
+      throw errors.broadcastFeedback.requestAlreadyInProcess();
+
     const broadcastConventionAgainEvent = deps.createNewEvent({
       topic: "ConventionBroadcastRequested",
       payload: {

diff --git a/back/src/domains/convention/use-cases/broadcast/BroadcastConventionAgain.unit.test.ts b/back/src/domains/convention/use-cases/broadcast/BroadcastConventionAgain.unit.test.ts
@@ -10,7 +10,11 @@ import {
   expectArraysToMatch,
   expectPromiseToFailWithError,
 } from "shared";
-import { makeCreateNewEvent } from "../../../core/events/ports/EventBus";
+import { DomainEvent } from "../../../core/events/events";
+import {
+  CreateNewEvent,
+  makeCreateNewEvent,
+} from "../../../core/events/ports/EventBus";
 import {
   BroadcastFeedback,
   broadcastToPeServiceName,
@@ -51,13 +55,14 @@ describe("BroadcastConventionAgain", () => {
   let broadcastConventionAgain: BroadcastConventionAgain;
   let uow: InMemoryUnitOfWork;
   let timeGateway: TimeGateway;
+  let createNewEvent: CreateNewEvent;
 
   beforeEach(async () => {
     uow = createInMemoryUow();
     const uowPerformer = new InMemoryUowPerformer(uow);
     const uuidGenerator = new TestUuidGenerator();
     timeGateway = new CustomTimeGateway();
-    const createNewEvent = makeCreateNewEvent({
+    createNewEvent = makeCreateNewEvent({
       uuidGenerator,
       timeGateway,
     });
@@ -199,5 +204,25 @@ describe("BroadcastConventionAgain", () => {
         }),
       );
     });
+
+    it("throws requestAlreadyInProcess when user request broadcast again before last broadcast request was published", async () => {
+      const lastUnpublishedBroadcastRequestEventDate = subHours(
+        addMinutes(timeGateway.now(), 12),
+        1,
+      ).toISOString();
+      const lastUnpublishedBroadcastRequestEvent: DomainEvent = createNewEvent({
+        topic: "ConventionBroadcastRequested",
+        occurredAt: lastUnpublishedBroadcastRequestEventDate,
+        status: "in-process",
+        payload: { convention, triggeredBy: null },
+      });
+
+      uow.outboxRepository.save(lastUnpublishedBroadcastRequestEvent);
+
+      await expectPromiseToFailWithError(
+        broadcastConventionAgain.execute({ conventionId }, adminUser),
+        errors.broadcastFeedback.requestAlreadyInProcess(),
+      );
+    });
   });
 });
diff --git a/back/src/domains/core/events/adapters/InMemoryOutboxRepository.ts b/back/src/domains/core/events/adapters/InMemoryOutboxRepository.ts
@@ -1,4 +1,5 @@
 import { values } from "ramda";
+import { ConventionId } from "shared";
 import { createLogger } from "../../../../utils/logger";
 import { DomainEvent, EventStatus } from "../events";
 import { OutboxRepository } from "../ports/OutboxRepository";
@@ -35,4 +36,22 @@ export class InMemoryOutboxRepository implements OutboxRepository {
       };
     });
   }
+
+  public async getLastUnpublishedConventionBroadcastRequestedEventByConventionId(
+    conventionId: ConventionId,
+  ): Promise<DomainEvent | undefined> {
+    const filteredEvents = values(this._events).filter(
+      (event) =>
+        event.topic === "ConventionBroadcastRequested" &&
+        event.status !== "published" &&
+        event.payload.convention.id === conventionId,
+    );
+
+    const sortedEvents = filteredEvents.sort(
+      (a, b) =>
+        new Date(b.occurredAt).getTime() - new Date(a.occurredAt).getTime(),
+    );
+
+    return sortedEvents[0] || undefined;
+  }
 }
diff --git a/back/src/domains/core/events/ports/OutboxRepository.ts b/back/src/domains/core/events/ports/OutboxRepository.ts
@@ -1,7 +1,11 @@
+import { ConventionId } from "shared";
 import { DomainEvent, EventStatus } from "../events";
 
 export interface OutboxRepository {
   countAllEvents(params: { status: EventStatus }): Promise<number>;
   save: (event: DomainEvent) => Promise<void>;
   markEventsAsInProcess: (events: DomainEvent[]) => Promise<void>;
+  getLastUnpublishedConventionBroadcastRequestedEventByConventionId: (
+    conventionId: ConventionId,
+  ) => Promise<DomainEvent | undefined>;
 }
diff --git a/shared/src/errors/errors.ts b/shared/src/errors/errors.ts
@@ -384,6 +384,10 @@ export const errors = {
           showGMT: true,
         })}. Merci d'essayer à nouveau dans ${params.formattedWaitingTime}.`,
       ),
+    requestAlreadyInProcess: () =>
+      new TooManyRequestApiError(
+        "Il y a déjà une synchronisation en cours. Cela peut prendre quelques instants. Merci de réessayer plus tard.",
+      ),
   },
   discussion: {
     badSiretFilter: () =>