Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add basic test for common methods #21

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

daywalker90
Copy link
Contributor

The plugin repo will require plugins to have tests in the future. So here is a basic test for

  • circular
  • circular-pull
  • circular-push
  • circular-stats

Unfortunately i could not get circular-push to work. You can see the error here: https://github.com/daywalker90/plugins/actions/runs/8782156065/job/24095700451#step:8:822

To run tests yourself:

pip3 install pyln-client pyln-testing
git clone https://github.com/giovannizotta/circular
cd circular/tests
./setup.sh # or provide the circular binary yourself inside the tests folder
cd ..
pytest tests/test_circular.py # or pytest -o log_cli=true --log-cli-level=INFO tests/test_circular to enable logging output

@giovannizotta
Copy link
Owner

Thanks a lot for your contribution! I will merge as-is, since the plugin repo considers the absence of test as much as a failure as a failing test. Let's investigate the issue with circular-push separately to not block this PR, as discussed

@giovannizotta giovannizotta merged commit 516317c into giovannizotta:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants