Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis' build on HHVM #115

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix Travis' build on HHVM #115

merged 1 commit into from
Jun 4, 2018

Conversation

SkUrRiEr
Copy link
Contributor

@SkUrRiEr SkUrRiEr commented Jun 4, 2018

Travis' HHVM doesn't seem to like aliased use statements, so this removes them from the only example test that uses them.

Of course if this fails to build I'll drop this hack.

@SkUrRiEr
Remove duplicate namespace includes
f40c008 
Travis' HHVM doesn't seem to like aliased use statements.
giorgiosironi
giorgiosironi approved these changes Jun 4, 2018
View reviewed changes
Copy link
Owner

@giorgiosironi giorgiosironi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loss of readability is small so it's a little price to pay

@giorgiosironi giorgiosironi merged commit 55de574 into giorgiosironi:master Jun 4, 2018
@SkUrRiEr SkUrRiEr deleted the fix-hhvm-build branch June 5, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorgiosironi giorgiosironi giorgiosironi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkUrRiEr @giorgiosironi