Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attempt to fix some gomod issue #1751

Merged
merged 1 commit into from
Jan 25, 2019
Merged

chore: attempt to fix some gomod issue #1751

merged 1 commit into from
Jan 25, 2019

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Jan 24, 2019

#1604 #1566 #1700 #1737

because some dependencies only are used on example i.e. grpc.

Or migrate examples to gin-gonic/examples`?

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #1751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1751   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          41       41           
  Lines        2042     2042           
=======================================
  Hits         2011     2011           
  Misses         19       19           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38a3fe...2eee701. Read the comment docs.

@thinkerou thinkerou requested a review from appleboy January 24, 2019 11:11
@appleboy appleboy merged commit d27685e into gin-gonic:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants