Prometheus No compression #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
起因于在暴露 Prometheus 采集端点时错误响应的问题。
经追查，因 `prometheus/client_golang` 在 `ServeHTTP()` 中会检查响应头(`Accept-Encoding`) 实现压缩，这样在启用`gzip`中间件后，会出现重复压缩。
现象: Prometheus 无法正常采集暴露信息，浏览器访问会直接下载。
以下三种方案:
1. 添加 `gzip` 白名单(此 PR 变更)
2. 将 `/metrics` 注册在 `gzip` 前面，避免压缩
3. 禁用 `prometheus/client_golang` 压缩(见下)
#### 禁用 prometheus/client_golang` 压缩
```go
// Prometheus 监控访问点
func Prometheus(c *gin.Context) {
func Prometheus(c *gin.Context) {
// register promhttp.HandlerOpts DisableCompression
promhttp.InstrumentMetricHandler(prometheus.DefaultRegisterer, promhttp.HandlerFor(prometheus.DefaultGatherer, promhttp.HandlerOpts{
DisableCompression: true,
})).ServeHTTP(c.Writer, c.Request)
//promhttp.Handler().ServeHTTP(c.Writer, c.Request)
}
```
dingdayu
added a commit
to dingdayu/godemo
that referenced
this pull request
Apr 7, 2020
gin-gonic/contrib#189 Signed-off-by: dingdayu <[email protected]>
|
We move discussion to https://github.com/gin-contrib/gzip |
appleboy
reviewed
Oct 1, 2020
There was a problem hiding this comment.
gzip move to https://github.com/gin-contrib/gzip now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
起因于在暴露 Prometheus 采集端点时错误响应的问题。
经追查，因
prometheus/client_golang在ServeHTTP()中会检查响应头(Accept-Encoding) 实现压缩，这样在启用gzip中间件后，会出现重复压缩。现象: Prometheus 无法正常采集暴露信息，浏览器访问会直接下载。
以下三种方案:
gzip白名单(此 PR 变更)/metrics注册在gzip前面，避免压缩prometheus/client_golang压缩(见下)禁用 prometheus/client_golang` 压缩