Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lazycell #94

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Switch to lazycell #94

merged 2 commits into from
Jun 7, 2018

Conversation

est31
Copy link
Contributor

@est31 est31 commented Jun 7, 2018

Lazycell has #![no_std] support. We give up sync-ness, but that's not needed for std inclusion.

@est31 est31 mentioned this pull request Jun 7, 2018
14 tasks
@philipc
Copy link
Contributor

philipc commented Jun 7, 2018

Can you also remove all the R: Sync bounds which were only there because Lazy needed them?

@est31
Copy link
Contributor Author

est31 commented Jun 7, 2018

@philipc I've removed the Sync bounds. With this change, will #93 still depend on your gimli PR gimli-rs/gimli#305 ?

@philipc
Copy link
Contributor

philipc commented Jun 7, 2018

No it won't, I'll redo #93 after this is merged.

@coveralls
Copy link

coveralls commented Jun 7, 2018

Coverage Status

Coverage remained the same at 81.395% when pulling 4a20169 on est31:master into 8f0a2f4 on gimli-rs:master.

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit c1203c6 into gimli-rs:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants