Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TF resources #121

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

SvenW
Copy link
Contributor

@SvenW SvenW commented Sep 30, 2024

I've added support for Terraform resources

@laszlocph laszlocph merged commit f4add76 into gimlet-io:main Oct 1, 2024
@SvenW SvenW deleted the feature/tf-resources branch October 1, 2024 18:02
@sebastiangaiser
Copy link
Contributor

sebastiangaiser commented Oct 1, 2024

@SvenW @laszlocph thank you for implementing this feature. After upgrading to v0.4.4 I got the following messages in the log due to not having the tofu-controller running in my cluster.

time="2024-10-01T19:55:32Z" level=info msg="Starting gitrepositories.source.toolkit.fluxcd.io controller"                                                                                                                           
time="2024-10-01T19:55:32Z" level=info msg="Starting ocirepositories.source.toolkit.fluxcd.io controller"                                                                                                                           
time="2024-10-01T19:55:32Z" level=info msg="Starting buckets.source.toolkit.fluxcd.io controller"                                                                                                                                   
time="2024-10-01T19:55:33Z" level=info msg="Starting helmrepositories.source.toolkit.fluxcd.io controller"                                                                                                                          
time="2024-10-01T19:55:34Z" level=info msg="Starting helmcharts.source.toolkit.fluxcd.io controller"                                                                                                                                
time="2024-10-01T19:55:34Z" level=info msg="Starting kustomizations.kustomize.toolkit.fluxcd.io controller"                                                                                                                         
time="2024-10-01T19:55:35Z" level=info msg="Starting helmreleases.helm.toolkit.fluxcd.io controller"                                                                                                                                
time="2024-10-01T19:55:35Z" level=info msg="Starting event controller"                                                                                                                                                              
time="2024-10-01T19:55:35Z" level=info msg="Starting deployment controller"                                                                                                                                                         
time="2024-10-01T19:55:35Z" level=info msg="Starting pod controller"                                                                                                                                                                
time="2024-10-01T19:55:35Z" level=info msg="Starting service controller"                                                                                                                                                            
time="2024-10-01T19:55:35Z" level=info msg="Starting ingress controller"                                                                                                                                                            
time="2024-10-01T19:55:35Z" level=warning msg="terraforms.infra.contrib.fluxcd.io is not supported on this cluster: the server could not find the requested resource"                                                               
time="2024-10-01T19:55:35Z" level=info msg=Initialized                                                                                                                                                                              
time="2024-10-01T19:55:36Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:36Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:41Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:41Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:41Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:41Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:49Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:49Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:49Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:55:49Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:03Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:03Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:03Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:04Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:04Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:05Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:05Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:44Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:44Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:44Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:44Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:53Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:53Z" level=warning msg="could not marshal event: the server could not find the requested resource"                                                                                                           
time="2024-10-01T19:56:53Z" level=warning msg="could not marshal event: the server could not find the requested resource"
...

Is there a chance to get the tofu-controller feature maybe on a feature flag? Just to mention it here, I added the apiGroup and resource to my Helm chart: sebastiangaiser/helm-charts@19dff1a

@SvenW
Copy link
Contributor Author

SvenW commented Oct 2, 2024

I noticed the same thing. Sorry for that. I've added a PR to fix the rbac issues but enabling/disabling the controller should maybe be configured via the env somehow

@SvenW
Copy link
Contributor Author

SvenW commented Oct 2, 2024

@laszlocph Do you want me to just add the controller behind an env var or do you have a plan for enabling disabling controllers via something else?

@laszlocph
Copy link
Contributor

v0.4.5 has the fix

flux reconcile source oci capacitor should pull it right in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants