Updated and documented esp32 secure behvior after discussion in issue #…

…18
gilmaimon · Jul 13, 2019 · 5f82069 · 5f82069
1 parent 80e5fcd
commit 5f82069
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -197,7 +197,7 @@ client.setFingerprint(ssl_fingerprint);
 ```
 
 ### ESP32
-With the esp32 there is only one option, `ArduinoWebsockets` supports validating the certificate chain by providing the `SSL Certificate` for the server's CA, for example:
+With the esp32 you could either provide the full certificate, or provide no certificate. An example for setting CA Certificate:
 ```c++
 const char ssl_ca_cert[] PROGMEM = \
     "-----BEGIN CERTIFICATE-----\n" \

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=ArduinoWebsockets
-version=0.4.5
+version=0.4.6
 author=Gil Maimon <[email protected]>
 maintainer=Gil Maimon <[email protected]>
 sentence=A library for writing modern Websockets applications with Arduino.

diff --git a/src/tiny_websockets/client.hpp b/src/tiny_websockets/client.hpp
@@ -73,9 +73,9 @@ namespace websockets {
       _endpoint.setUseMasking(useMasking);
     }
 
+    void setInsecure();
   #ifdef ESP8266
     void setFingerprint(const char* fingerprint);
-    void setInsecure();
   #elif defined(ESP32)
     void setCACert(const char* ca_cert);
   #endif

diff --git a/src/websockets_client.cpp b/src/websockets_client.cpp
@@ -506,7 +506,11 @@ namespace websockets {
 #elif defined(ESP32)
     void WebsocketsClient::setCACert(const char* ca_cert) {
         this->_optional_ssl_ca_cert = ca_cert;
-    }  
+    }
+
+    void WebsocketsClient::setInsecure() {
+        this->_optional_ssl_ca_cert = nullptr;
+    }
 #endif
 
     WebsocketsClient::~WebsocketsClient() {