Add exclude_by_attribute preference to exclude files based on xattr #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add preference
exclude_by_attribute
(boolean). If true:com.apple.metadata:com_apple_backup_excludeItem
that contain the valuecom.apple.backupd
.dulicacy_exclude
.Tests Included, tested on macOS afps and Debian ext4
Fixes #478
I named the preference "exclude_by_attribute" and not "exclude_attribute" to make it clear this doesn't affect the storage of attributes on the files.
Alternatively this could be named something like "file_exclude_attribute"
Discussion:
DUPLICACY_ATTRIBUTE_THRESHOLD
. I didn't change the existing code to force a read of the attributes when this occurs. However I think that ifexclude_by_attribute
is true that it should read the attributes and discard them at least (or callxattr.Getxattr
directly on the file ifdiscardAttributes
is true). Based on input I can update the pull request.bool
into amap[string]string
like the Keys preference. Based on input I can update the pull request.