Docker-machine addred suport to Vsphere for extra arument #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker-machine create() added one more list parameter, it will suport vmwarevsphere create.
gijzelaerr
requested changes
Jan 24, 2018
machine/machine.py
Outdated
| @@ -86,7 +86,7 @@ def version(self): | |||
| match = self._match(cmd, regexp) | |||
| return match.group(1) | |||
|
|
|||
| def create(self, name, driver='virtualbox', blocking=True): | |||
| def create(self, name, driver='virtualbox', blocking=True, xarg=[]): | |||
There was a problem hiding this comment.
Thanks for your PR!
This is not a good idea:
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments
There was a problem hiding this comment.
yes, you are right. Done the changes as you suggested.
machine/machine.py
Outdated
| @@ -99,7 +99,10 @@ def create(self, name, driver='virtualbox', blocking=True): | |||
| Returns: | |||
| int: error code from the run | |||
| """ | |||
| cmd = ['create', '--driver', driver, name] | |||
| cmd = ['create', '--driver', driver] | |||
There was a problem hiding this comment.
This can be written as `cmd = ['create', '--driver', driver] + xarg + [name]
There was a problem hiding this comment.
Done the changes as you suggested.
1) Removed Mutable Default Arguments 2) cmd argument list merge modified.
|
perfect thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Creating Vsphere Vcenter machine , it need extra argument, so added list for xarg.
this list will contain create parameter.