Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module stability #24

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

sidepelican
Copy link
Contributor

Add compile option for convenience BUILD_LIBRARY_FOR_DISTRIBUTION = YES.
The difference of swift version can be ignore with this option.

I referenced this commit.
kishikawakatsumi/KeychainAccess@e20f21f#diff-58bea6d1dedfc8e4cf8e734d08980dd0

@sidepelican
Copy link
Contributor Author

I have tested that compiling Crossroad using Carthage with Xcode 11.1 and it can use with Xcode 11.2 Beta 2

Copy link
Owner

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch ✨

I'll release newer version soon.

@giginet giginet merged commit 2ba5882 into giginet:master Nov 6, 2019
@sidepelican sidepelican deleted the module_stability branch November 6, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants