Skip to content

Commit

Permalink
Add tests for Node.js version 21
Browse files Browse the repository at this point in the history
  • Loading branch information
giggio committed Nov 1, 2023
1 parent c99283d commit 5b708ad
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
&& chmod 0440 /etc/sudoers.d/$USERNAME
USER $USERNAME
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 20" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0 && nvm i --no-progress 21.1.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 21" ]
ENV DEBIAN_FRONTEND=dialog
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["18.x", "20.x"]
node: ["18.x", "20.x", "21.x"]
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["18", "20"]
node: ["18", "20", "21"]
steps:
- uses: actions/checkout@v4
- uses: uraimo/[email protected]
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["18", "20"]
node: ["18", "20", "21"]
steps:
- uses: actions/checkout@v4
- uses: uraimo/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion testInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');
const spawnSync = require('child_process').spawnSync;
const versions = ['18', '20'];
const versions = ['18', '20', '21'];
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');

Expand Down

0 comments on commit 5b708ad

Please sign in to comment.