-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on OpenCV for capture and encoding #9
Comments
That makes sense. One thing we discussed a long time ago though was to be able to decorate/adapt a VideoFrame (https://github.com/gift-surg/GIFT-Grab/blob/master/src/api/videoframe.h) to present it as an OpenCV image if OpenCV is specified as a dependency. This would ease integrating GIFT-Grab in processing pipelines. |
|
A more thorough search, which:
has revealed that OpenCV is also used for capturing BGRA frames from Epiphan frame grabbers.
For instance Epiphan SDK provides the
|
This thread might be useful for supporting BGRA capture with libVLC. |
A video-4-linux example https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/v4l2grab.c.html potentially useful for #9 (comment) |
There's OpenCV color conversion involved in the current implementation, so we could as well use the Epiphan SDK's |
|
FFmpeg seems to nail it:
|
As per #10, OpenCV compatibility is an important feature for many (but not all) users. Should we rename this issue as "Make OpenCV dependency optional" or "Remove mandatory core dependency on OpenCV"? |
@tvercaut Agreed, I've updated the title and the description to make this issue more specific. |
GIFT-Grab uses OpenCV for:
decodingHowever OpenCV depends on FFmpeg, presumably for these tasks. FFmpeg is already used in GIFT-Grab as well. And OpenCV is quite a heavy-weight dependency in this regard. So it might be worth removing it in favour of using FFmpeg for all that OpenCV is needed for in GIFT-Grab.
With this, the OpenCV dependency will become optional, and for the time being confined to #10
The text was updated successfully, but these errors were encountered: