Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "user" tests installed via pip #24

Open
dzhoshkun opened this issue Oct 17, 2018 · 5 comments
Open

Remove "user" tests installed via pip #24

dzhoshkun opened this issue Oct 17, 2018 · 5 comments
Labels
to investigate
Milestone
31 12 2020

Comments

@dzhoshkun
Copy link
Contributor

The tests that are executed as part of the CI routine via CTest are also installed via pip as test-giftgrab-* console scripts that get populated automatically.
As far as I remember the idea behind this was to provide the user with a way to test a pip-installed GIFT-Grab.
However these are not even documented, so the user has no way to know about these, as a matter of fact (the more advanced user who can dig these out should be able to figure on their own how to test a pip-installed GIFT-Grab 😄 )
On the contrary, this causes problems such as this.
@dzhoshkun
Copy link
Contributor Author

The CI script calls to these could be replaced by the corresponding pytest calls.

@dzhoshkun
Copy link
Contributor Author

dzhoshkun commented Oct 18, 2018 •
edited
Loading

  • revise commands in device-specific CI script sections as well

dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: added a Bash script file for selectively running the tests…
8b428d4 
… with a convenient CLI
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: fixed typo
7f23b55
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: replaced active test-giftgrab-* commands of "pypi" CI sect…
b1c51e1 
…ion with new script CLI commands
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: replaced inactive test-giftgrab-* commands of "pypi" CI se…
dd05196 
…ction with new script CLI commands
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: fixed path to test launcher script
465065b
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: made test launcher script executable
d080b54
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: added usage info to test launcher script
19670a2
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: test launcher script now validates no of args
0b913ec
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: added functions to test launcher for parsing colour and codec
88cfce4
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: added an exception for NumPy tests as they do not support …
f7bdf42 
…UYVY yet
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: implemented command composition in test launch script, onl…
a067cf7 
…y echoeing the command for now
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: documented launch script
dc61875
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: actually running composed command in launch script
0e88cae
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: echoeing exit code after actually running command in launc…
2abf5b6 
…h script
@dzhoshkun dzhoshkun mentioned this issue Oct 18, 2018
Closed
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: revised variable names for clarity
0782a28
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: documented launch script
5ae5307
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: actually running composed command in launch script
77df3ae
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: echoeing exit code after actually running command in launc…
88fc35a 
…h script
@dzhoshkun dzhoshkun mentioned this issue Oct 18, 2018
Merged
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed test-giftgrab-numpy-* console scripts
d537331
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed actual implementation of test-giftgrab-numpy-* con…
f4eb2fb 
…sole scripts
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed test-giftgrab-file-* console scripts
1f61517
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed actual implementation of test-giftgrab-file-* cons…
0b2dc82 
…ole scripts
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed test-giftgrab-* console scripts
3578a20
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: removed actual implementation of test-giftgrab-* console s…
3cfec0d 
…cripts
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: setting path to convenience script before all CI script fo…
393e1c1 
…r global availability
dzhoshkun added a commit that referenced this issue Oct 18, 2018
@dzhoshkun
Issue #24: renamed envvar for test launcher for clarity
e210b18
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24: added support for Epiphan DVI2PCIe duo to test launcher
f5f7980
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24, #26: replaced test-giftgrab-epiphan-* calls with calls to …
8716e84 
…test launcher script in CI config
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24, #26: removed test-giftgrab-epiphan-dvi2pcieduo-i420 consol…
080cc60 
…e script
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24, #26: removed actual implementation of both test-giftgrab-e…
961622f 
…piphan-dvi2pcieduo-* console scripts
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24, #26: removed note about both test-giftgrab-epiphan-dvi2pci…
90940ab 
…eduo-bgra console script
dzhoshkun added a commit that referenced this issue Oct 22, 2018
@dzhoshkun
Issue #24, #26: removed installation of "test-giftgrab-epiphan-*"-rel…
a1bc2a8 
…ated package data
@dzhoshkun
Copy link
Contributor Author

  • run above commit with an Epiphan device

@dzhoshkun dzhoshkun mentioned this issue Oct 22, 2018
Closed
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: added support for Epiphan DVI2PCIe duo to test launcher
6db0a41
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: replaced test-giftgrab-epiphan-* calls with calls to …
a7b28de 
…test launcher script in CI config
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: removed test-giftgrab-epiphan-dvi2pcieduo-i420 consol…
108bc0e 
…e script
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: removed actual implementation of both test-giftgrab-e…
42685d5 
…piphan-dvi2pcieduo-* console scripts
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: removed note about both test-giftgrab-epiphan-dvi2pci…
8074953 
…eduo-bgra console script
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: removed installation of "test-giftgrab-epiphan-*"-rel…
f7b80f9 
…ated package data
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24, #26: using only Epiphan DVI port tests in CI script (no DV…
4ded35a 
…I source connected to Kyrie) and activated respective CI sections for current branch
@dzhoshkun
Copy link
Contributor Author

dzhoshkun commented Oct 24, 2018 •
edited
Loading

  • revert above commit!

dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: removed edd-* calls in CI script
73b6a94
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: removed edd-* console scripts from setup.py
c5481aa
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: removed actual implementation of edd-* console scripts
9d4bb4f
@dzhoshkun dzhoshkun mentioned this issue Oct 24, 2018
Merged
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: running only the PyPI CI script for Epiphan device to chec…
681f08a 
…k pip-installability
@dzhoshkun
Copy link
Contributor Author

dzhoshkun commented Oct 24, 2018 •
edited
Loading

  • revert above commit as well

dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: fixed passing of Epiphan CLI argument to test launcher in …
b4ed531 
…CI script
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: fixed Epiphan tests call in test launcher script
50fb2bb
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Issue #24: fixed test working directory specification of Epiphan test…
cb9a387 
…s in test launcher
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Revert "Issue #24: running only the PyPI CI script for Epiphan device…
b2772f2 
… to check pip-installability"

This reverts commit 681f08a.
dzhoshkun added a commit that referenced this issue Oct 24, 2018
@dzhoshkun
Revert "Issue #24, #26: using only Epiphan DVI port tests in CI scrip…
1e27037 
…t (no DVI source connected to Kyrie) and activated respective CI sections for current branch"

This reverts commit 4ded35a.
@dzhoshkun dzhoshkun mentioned this issue Oct 25, 2018
Closed
@joubs joubs added this to the 31 12 2020 milestone Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to investigate
Projects
None yet
Milestone
31 12 2020
Development

No branches or pull requests
2 participants
@dzhoshkun @joubs