-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Action] Fix for failure case #20
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #20. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
1fc79df
to
8ecccd4
Compare
Even if the step failed, the `continue-on-error` was used to continue the next step. But `continue-on-error` marks success even if the step fails. So, let's use `always()` for subsquent steps. Signed-off-by: Gichan Jang <[email protected]>
cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md |
To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself. |
cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md |
To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself. |
cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md |
cibot: @gichan-jang, apptest could not be completed. To find out the reasons, please go to http://ci.nnstreamer.ai//nnstreamer-gichan/ci/repo-workers/pr-checker/20-202411151516490.73944902420044-6694b3ac6dd56e01ece82c136c8e55c2c8b59692 |
edca999
to
203b880
Compare
Even if the step failed, the
continue-on-error
was used to continue the next step. Butcontinue-on-error
marks success even if the step fails. So, let's usealways()
for subsquent steps.[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.