Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action] Fix for failure case #20

Closed
wants to merge 1 commit into from
Closed

[Action] Fix for failure case #20

wants to merge 1 commit into from

Conversation

gichan-jang
Copy link
Owner

Even if the step failed, the continue-on-error was used to continue the next step. But continue-on-error marks success even if the step fails. So, let's use always() for subsquent steps.


[Template] PR Description

In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.

$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused 
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [*]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #20. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@gichan-jang gichan-jang force-pushed the temp branch 8 times, most recently from 1fc79df to 8ecccd4 Compare November 15, 2024 06:08
Even if the step failed, the `continue-on-error` was used to continue the next step.
But `continue-on-error` marks success even if the step fails.
So, let's use `always()` for subsquent steps.

Signed-off-by: Gichan Jang <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

:octocat: cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

:octocat: cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

:octocat: cibot: @gichan-jang, gst/nnstreamer/elements/gsttensor_converter.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@taos-ci
Copy link
Collaborator

taos-ci commented Nov 15, 2024

@gichan-jang gichan-jang force-pushed the main branch 3 times, most recently from edca999 to 203b880 Compare November 27, 2024 05:16
@gichan-jang gichan-jang closed this Dec 9, 2024
@gichan-jang gichan-jang deleted the temp branch December 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants