Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cover position handling #77

Merged
merged 7 commits into from
May 6, 2024
Merged

Fixed cover position handling #77

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4493c3
Inverted cover position to match home assistant's definition
optiluca Apr 11, 2023
54079cb
Merge branch 'master' of https://github.com/optiluca/homeassistant-co…
optiluca Apr 11, 2023
9c6a855
Merge branch 'gicamm:master' into master
optiluca Jul 23, 2023
06afed7
Merge branch 'gicamm:master' into master
optiluca May 4, 2024
0061bab
Update all async_schedule_update_ha_state calls to their non-async co…
optiluca May 4, 2024
3dccde4
Fixed position=None handling (was causing closed covers to be misrepo…
optiluca May 6, 2024
3233ae2
Merge branch 'gicamm:master' into master
optiluca May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions custom_components/comelit/cover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ def is_closing(self):

@property
def current_cover_position(self): # -> int | None:
if self._position: # if not None:
return 100 - self._position
if self._position is None:
return None
else:
return self._position
return 100 - self._position

def set_cover_position(self, position, **kwargs):
_LOGGER.debug(f"Trying to SET POSITION {position} cover {self.name}! _state={self._state}")
Expand Down
Loading