Fixed the fix - color_mode should *not* be a set. Also, bool comparis…

…ons with None is risky (e.g. a dimmable light with 0 brighness would suddenly stop being registered as dimmable), so fixed that as well.
gicamm · Sep 15, 2024 · 9fc26b1 · 9fc26b1
1 parent 1ce7d60
commit 9fc26b1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/custom_components/comelit/light.py b/custom_components/comelit/light.py
@@ -32,11 +32,11 @@ def is_on(self):
 
     @property
     def supported_color_modes(self):
-        return {ColorMode.BRIGHTNESS} if self._brightness else {ColorMode.ONOFF}
+        return {ColorMode.BRIGHTNESS} if self._brightness is not None else {ColorMode.ONOFF}
 
     @property
     def color_mode(self):
-        return {ColorMode.BRIGHTNESS} if self._brightness else {ColorMode.ONOFF}
+        return ColorMode.BRIGHTNESS if self._brightness is not None else ColorMode.ONOFF
 
     @property
     def brightness(self):