Skip to content

Commit

Permalink
Adapt to lib-common fix in PR openstack-k8s-operators#231
Browse files Browse the repository at this point in the history
In openstack-k8s-operators/lib-common#231
lib-common fixed typos in condition messages. This patch adapts our test
to the changed messages
  • Loading branch information
gibizer committed Apr 4, 2023
1 parent 3d62572 commit d97eaf5
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 23 deletions.
8 changes: 4 additions & 4 deletions test/functional/nova_metadata_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ var _ = Describe("NovaMetadata controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -406,7 +406,7 @@ var _ = Describe("NovaMetadata controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -559,7 +559,7 @@ var _ = Describe("NovaMetadata controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
th.ExpectConditionWithDetails(
Expand All @@ -568,7 +568,7 @@ var _ = Describe("NovaMetadata controller", func() {
condition.ReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand Down
8 changes: 4 additions & 4 deletions test/functional/nova_scheduler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ var _ = Describe("NovaScheduler controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -388,7 +388,7 @@ var _ = Describe("NovaScheduler controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -494,7 +494,7 @@ var _ = Describe("NovaScheduler controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand All @@ -504,7 +504,7 @@ var _ = Describe("NovaScheduler controller", func() {
condition.ReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand Down
8 changes: 4 additions & 4 deletions test/functional/novaapi_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ var _ = Describe("NovaAPI controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -489,7 +489,7 @@ var _ = Describe("NovaAPI controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -666,7 +666,7 @@ var _ = Describe("NovaAPI controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
th.ExpectConditionWithDetails(
Expand All @@ -675,7 +675,7 @@ var _ = Describe("NovaAPI controller", func() {
condition.ReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand Down
4 changes: 2 additions & 2 deletions test/functional/novacell_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ var _ = Describe("NovaCell controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand All @@ -239,7 +239,7 @@ var _ = Describe("NovaCell controller", func() {
condition.ReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand Down
14 changes: 7 additions & 7 deletions test/functional/novaconductor_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.DBSyncReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"DBsync job error occured Internal error occurred: Job Failed. Check job logs",
"DBsync job error occurred Internal error occurred: Job Failed. Check job logs",
)
// This would fail the test case if the job does not exists
th.GetJob(jobName)
Expand All @@ -332,7 +332,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.DBSyncReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"DBsync job error occured Internal error occurred: Job Failed. Check job logs",
"DBsync job error occurred Internal error occurred: Job Failed. Check job logs",
)

DeleteInstance(GetNovaConductor(novaConductorName))
Expand Down Expand Up @@ -452,7 +452,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.DBSyncReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"DBsync job error occured Internal error occurred: Job Failed. Check job logs",
"DBsync job error occurred Internal error occurred: Job Failed. Check job logs",
)
Expect(th.GetJob(jobName).Spec.TTLSecondsAfterFinished).To(BeNil())
})
Expand Down Expand Up @@ -573,7 +573,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -613,7 +613,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)
})
Expand Down Expand Up @@ -728,7 +728,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.NetworkAttachmentsReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand All @@ -738,7 +738,7 @@ var _ = Describe("NovaConductor controller", func() {
condition.ReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"NetworkAttachments error occured "+
"NetworkAttachments error occurred "+
"not all pods have interfaces with ips as configured in NetworkAttachments: [internalapi]",
)

Expand Down
4 changes: 2 additions & 2 deletions test/functional/novaexternalcompute_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ var _ = Describe("NovaExternalCompute", func() {
condition.InputReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"Input data error occured field 'inventory' not found in configmap/"+compute.Spec.InventoryConfigMapName,
"Input data error occurred field 'inventory' not found in configmap/"+compute.Spec.InventoryConfigMapName,
)
compute = GetNovaExternalCompute(computeName)
Expect(compute.Status.Hash["input"]).To(BeEmpty())
Expand Down Expand Up @@ -243,7 +243,7 @@ var _ = Describe("NovaExternalCompute", func() {
condition.InputReadyCondition,
corev1.ConditionFalse,
condition.ErrorReason,
"Input data error occured field 'ssh-privatekey' not found in secret/"+compute.Spec.SSHKeySecretName,
"Input data error occurred field 'ssh-privatekey' not found in secret/"+compute.Spec.SSHKeySecretName,
)
compute = GetNovaExternalCompute(computeName)
Expect(compute.Status.Hash["input"]).To(BeEmpty())
Expand Down

0 comments on commit d97eaf5

Please sign in to comment.