Point silence operator to mimir #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
migrate-silences-to-mimir
branch
from
548397a to
8006b06
Compare
|
|
TheoBrigitte
requested changes
Jun 27, 2024
| @@ -16,6 +16,7 @@ data: | |||
| service: | |||
| alertmanager: | |||
| address: {{ .Values.alertmanagerAddress }} | |||
| tenantId: anonymous | |||
There was a problem hiding this comment.
This value should be configurable via values
helm/silence-operator/values.yaml
Outdated
| @@ -2,7 +2,7 @@ image: | |||
| name: "giantswarm/silence-operator" | |||
| tag: "[[ .Version ]]" | |||
|
|
|||
| alertmanagerAddress: http://alertmanager-operated.monitoring.svc:9093 | |||
| alertmanagerAddress: http://mimir-gateway.mimir.svc:8080/alertmanager | |||
There was a problem hiding this comment.
Let's not make this a default here, but instead use a placeholder
pkg/alertmanager/mimirclient.go
Outdated
| ) | ||
|
|
||
| type httpClient struct { | ||
| c http.Client |
There was a problem hiding this comment.
http.Client should rather be embedded in httpClient in order to avoid obfuscation of the client capabilities.
This would also prevent redefining all the client method done below.
There was a problem hiding this comment.
Sure that would be best but there's no way to call the do function of the http.client thought right?
QuentinBisson
commented
Jun 27, 2024
QuentinBisson
commented
Oct 28, 2024
QuentinBisson
commented
Oct 28, 2024
|
|
||
| func (t *customTransport) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| if t.tenantId != "" { | ||
| req.Header.Add("X-Scope-OrgID", t.tenantId) |
There was a problem hiding this comment.
We use a transport to avoid overrding functions of the http client
2 tasks
|
@TheoBrigitte what do you think? |
TheoBrigitte
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist