-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPV: Release v29.0.0. #1459
CAPV: Release v29.0.0. #1459
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
583767c
to
d5c9eba
Compare
070d09e
to
2ff2c65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have observability-bundle 1.7.0
as part of this release ?
b909de4
to
875a40f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@vxav: Tests are failing, because the image hasn't been copied to vSphere, yet. Can you make sure the image for Flatcar 3975.2.2, Kubernetes 1.29.10 and OS Tooling 1.20.1 is present? Thank you! |
This comment was marked as outdated.
This comment was marked as outdated.
Copied it 👍🏻 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The same Now it seems like you recently introduced a change to the As a customer I'd expect these releases to be tested and working, so cluster creation shouldn't break out of nowhere. Can you please elaborate on what has been changed in |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/run releases-test-suites TARGET_SUITES=./providers/capv/standard PREVIOUS_RELEASE=28.0.1 TARGET_RELEASES=vsphere-29.0.0 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
@giantswarm/team-rocket I think we can finally move on, if you could take another look? |
/run releases-test-suites TARGET_SUITES=./providers/capv/upgrade PREVIOUS_RELEASE=28.0.1 TARGET_RELEASES=vsphere-29.0.0 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
/run releases-test-suites TARGET_SUITES=./providers/capv/upgrade PREVIOUS_RELEASE=28.0.1 TARGET_RELEASES=vsphere-29.0.0 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
/run releases-test-suites TARGET_SUITES=./providers/capv/upgrade PREVIOUS_RELEASE=28.0.1 TARGET_RELEASES=vsphere-29.0.0 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
/run releases-test-suites TARGET_SUITES=./providers/capv/upgrade PREVIOUS_RELEASE=28.0.1 TARGET_RELEASES=vsphere-29.0.0 |
@QuentinBisson or someone else from @giantswarm/team-atlas: Can you please reply to this? It would be very helpful, even if only for documentation. Also I'd be interested in what has changed between the different runs of Releases Test Suites as I'd prefer to see them reliably fixed instead of having them pass once out of ten. 🙂 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
@Gacko I'll write something on monday, I wanted to focus on fixing this first but I did not forget your message :) |
Ok, thank you! I'll run the standard tests one last time and merge this PR once they pass. /run releases-test-suites TARGET_SUITES=./providers/capv/standard TARGET_RELEASES=vsphere-29.0.0 |
There's currently a fixed branch of the logging operator on gcapeverde so tests should work 🤞🏻 |
I was going to run them again anyway 😅 |
releases-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: Tip To only re-run the failed test suites you can provide a Alternatively, or in addition to, you can also specify |
We are indeed configuring the observability-platform apps in releases via operators. We initialy built the logging and observability operators as a safety mechanism to be able to change some of our apps config on the fly (for prometheus-agent and so on) to counteract the lack/slowness of customer upgrades in the past because we were swarmed with lots of day and night alerts and that was unsufferable and waiting for a customer to upgrade was a no-go. We used this mechanism to build some features on our apps as well like:
This used to work quite well in the past but we recently enabled a feature flag on the logging-operator that replaced promtail with alloy in the observability platform giantswarm/logging-operator#246 which caused issues last week. This changed had been manually tested in the past but it missed that the grafana-agent application was failing to deploy (because of an issue with it's CRD management in our currently deployed release of it) which broke the cluster creation test. In the mean time, a configuration breaking change in the alloy secret management was introduced in the observability-bundle and the change was not properly reflected in the logging-operator which caused the upgrade test to fail because the secret for alloy was not created and so alloy in CAPV 28 did not actually deploy :( Last week, this became problematic and we are definitely sorry about all of this :(. I am opening a PM today so we can investigate how we can move forward without a lot of the operator work going on behind the hood (we need some config coming from MCs like secret to talk to loki and so on but not as much as we have today) but it should be our priority that we find something that does not break any existing releases. By the way, we've been having discussions about this topic for years now and I really thought everyone was aware of it. We really need to find a better way to move forward (cc @JosephSalisbury) and that will require improvements on the release and delivery process as well :) |
Towards: giantswarm/roadmap#3710
Checklist
Triggering E2E tests
To trigger the E2E test for each new Release added in this PR, add a comment with the following:
/run releases-test-suites
If you want to trigger conformance tests, you can do so by adding a comment similar to the following:
/run conformance-tests PROVIDER=capa RELEASE_VERSION=29.1.0
For more details see the README.md.