Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prometheusagentfailing inhibition #911

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR adds missing PrometheusAgentDown inhibition on relevant alerts

Checklist

@QuentinBisson QuentinBisson requested a review from a team September 19, 2023 09:00
@QuentinBisson QuentinBisson requested a review from a team as a code owner September 19, 2023 09:00
@QuentinBisson QuentinBisson self-assigned this Sep 19, 2023
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 737a5e9 into master Sep 19, 2023
@QuentinBisson QuentinBisson deleted the add-missing-inhibition-to-ksm-down branch September 19, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants