Change certificates expiration from 14 to 13 days #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this is a bug in cert manager. The Certificates we have contain the CA that they've been signed with. When a CA has been renewed, the Certificates that use it will not be updated until they themselves are renewed. This causes an issue because the Certificate (in KIAM's case) will renew a few hours after the CA. This is enough time for the CA in the kiam certificate to expire and cause a flurry of alerts. This has mainly been observed with KIAM, but we decided to change all alerts. See cert-manager/cert-manager#5851
primeroz
approved these changes
May 15, 2023
whites11
reviewed
May 15, 2023
| @@ -60,7 +60,7 @@ spec: | |||
| annotations: | |||
| description: '{{`Certificate CR {{ $labels.namespace }}/{{ $labels.name }} on {{ $labels.cluster_id }} will expire in less than two weeks.`}}' | |||
| opsrecipe: managed-app-cert-manager/certificate-secret-will-expire-in-less-than-two-weeks/ | |||
| expr: (cert_exporter_certificate_cr_not_after{managed_issuer="true",namespace=~"kube-system|giantswarm|monitoring"} - time()) < 2 * 7 * 24 * 60 * 60 | |||
| expr: (cert_exporter_certificate_cr_not_after{managed_issuer="true",namespace=~"kube-system|giantswarm|monitoring"} - time()) < 13 * 24 * 60 * 60 | |||
whites11
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is a bug in cert manager. The Certificates we have contain the CA that they've been signed with. When a CA has been renewed, the Certificates that use it will not be updated until they themselves are renewed. This causes an issue because the Certificate (in KIAM's case) will renew a few hours after the CA. This is enough time for the CA in the kiam certificate to expire and cause a flurry of alerts.
This has mainly been observed with KIAM, but we decided to change all alerts.
See cert-manager/cert-manager#5851 for cert-manager bug
See https://gigantic.slack.com/archives/C020E38NGTZ/p1684138271354269 for discussion around this.
Checklist
oncall-kaas-cloudGitHub group).