Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove label replace on CAPI for app_operator_app_info alerts and use cluster_id from the metric #1441

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Remove label replace on CAPI for app_operator_app_info alerts and use cluster_id from the metric #1441

merged 3 commits into from
Nov 27, 2024

Conversation

uvegla
Copy link
Contributor

@uvegla uvegla commented Nov 26, 2024 •
edited
Loading

Towards: https://github.com/giantswarm/giantswarm/issues/32126

Related to: giantswarm/app-exporter#507

Checklist

@uvegla uvegla requested a review from a team as a code owner November 26, 2024 14:05
@uvegla uvegla requested a review from QuentinBisson November 26, 2024 14:28
QuentinBisson
QuentinBisson approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uvegla uvegla merged commit f137639 into main Nov 27, 2024
7 checks passed
@uvegla uvegla deleted the update-app-exporter-rules branch November 27, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uvegla @QuentinBisson