improve mimir compactor failures detection #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervenicol
force-pushed
the
mimir-compactor-improvement
branch
from
e0567a4 to
572d413
Compare
| @@ -158,8 +158,7 @@ spec: | |||
| dashboard: 09a5c49e9cdb2f2b24c6d184574a07fd/mimir-compactor-resources | |||
| description: 'Mimir compactor has been failing its compactions for 2 hours.' | |||
| opsrecipe: mimir#mimircompactorfailedcompaction | |||
| # Query is based on the following upstream mixin alerting rule : https://github.com/grafana/mimir/blob/main/operations/mimir-mixin-compiled/alerts.yaml#L858 | |||
| expr: sum(increase(cortex_compactor_runs_failed_total{reason!="shutdown"}[2h])) by (cluster_id, installation, namespace, pipeline, provider) > 2 | |||
| expr: min by (cluster_id, installation, namespace, provider, pipeline) (time() - (cortex_compactor_last_successful_run_timestamp_seconds)) > 60 * 60 * 2 | |||
There was a problem hiding this comment.
Any reason why you removed the comment?
There was a problem hiding this comment.
Because it's not based on the upstream mixin alerting rule anymore. So the comment does not make sense anymore.
There was a problem hiding this comment.
Sure, i'm tired 😅
Anyway, as you say, the alert does not fire if the value is 0 and that's why they need to have the since startup alert in both Loki and Mimir
There was a problem hiding this comment.
Oooh, I finally remember this 0 condition and why the unit tests work! Because time() starts at 0 for the tests! 🤦
I'll fix it then.
There was a problem hiding this comment.
Should be fixed 😁
There was a problem hiding this comment.
Oh yes that time function is tricky
QuentinBisson
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: https://github.com/giantswarm/giantswarm/issues/32027
This PR improves Mimir compaction issues detection. See main issue for details.
Checklist
oncall-kaas-cloudGitHub group).