Updated cluster_release_version to support CAPI clusters
#1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o support CAPI clusters Signed-off-by: Marcus Noble <[email protected]>
njuettner
approved these changes
Oct 25, 2024
| @@ -121,7 +121,10 @@ spec: | |||
| {{- end }} | |||
| ) | |||
| record: aggregation:giantswarm:cluster_info | |||
| - expr: sum(cluster_service_cluster_info) by (release_version, cluster_id, cluster_type, customer, installation, pipeline, provider, region) / 2 or sum(cluster_operator_cluster_status{release_version!=""}) by (release_version, cluster_id, cluster_type, customer, installation, pipeline, provider, region) | |||
| - expr: |- | |||
There was a problem hiding this comment.
LGTM if it was tested :)
There was a problem hiding this comment.
I've tested the expression query itself manually on both vintage and capi instances. Is there a better way to test it as an aggregation itself? I'm a bit out of my comfort zone here 😅
There was a problem hiding this comment.
Easy solution is to deploy the rule on a test mc and check out the metrics on grafana cloud I think :) you should sée thé clusters showing up on the cluster dashboard on grafana cloud
QuentinBisson
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: giantswarm/roadmap#3650
This PR updates the expression used by
aggregation:giantswarm:cluster_release_versionto support CAPI clusters by getting the release version fromcapi_cluster_info.Checklist
oncall-kaas-cloudGitHub group).