Alert StatefulsetNotSatisfiedAtlas alert #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| description: '{{`Statefulset {{ $labels.namespace}}/{{ $labels.statefulset }} is not satisfied.`}}' | ||
| opsrecipe: deployment-not-satisfied/ | ||
| expr: |- | ||
| kube_statefulset_status_replicas{cluster_type="management_cluster", statefulset=~"loki.*|mimir.*"} |
There was a problem hiding this comment.
Maybe we use namespace instead lf statefulset? The values would be the same but we would not need to use regex?
There was a problem hiding this comment.
I wanted to stick to the current deploymentnotsatisfied alert's behaviour.
I guess the reason why it's based on the pod name is for apps running in kube-system, where we have to filter by pod name to then route to the proper team.
So, for today/current case, filtering by namespace would work, but if we want to add a kube-system statefulset to the alert we would have to revert.
QuentinBisson
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#3719
This PR an alert when a deployment has not all the expected pods running.
Related opsrecipe change here: https://github.com/giantswarm/giantswarm/pull/31903
Checklist
oncall-kaas-cloudGitHub group).