Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move alloy namespace #1299

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


This PR moves alloy in the monitoring namespace because it is now used for both mimir and loki

Checklist

@QuentinBisson QuentinBisson self-assigned this Jul 15, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner July 15, 2024 12:21
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if successfully tested.

Copy link
Member

@TheoBrigitte TheoBrigitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine, but please make sure you test this before merging.

@QuentinBisson
Copy link
Contributor Author

Tested and working

@QuentinBisson QuentinBisson merged commit d89caf0 into main Jul 15, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the move-alloy-from-mimir-to-monitoring-namespace branch July 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants