Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ready replicas for KyvernoWebhookHasNoAvailableReplicas #1224

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

fhielpos
Copy link
Member

@fhielpos fhielpos commented Jun 6, 2024

From: https://github.com/giantswarm/giantswarm/issues/31003

Uses ready replicas instead of just the current status replicas for the KyvernoWebhookHasNoAvailableReplicas alert. This ensure the alert fires even when pods are Pending.

@fhielpos fhielpos requested a review from a team as a code owner June 6, 2024 22:40
@fhielpos fhielpos self-assigned this Jun 6, 2024
@fhielpos fhielpos requested a review from a team June 6, 2024 22:40
@Strigix
Copy link
Contributor

Strigix commented Jun 10, 2024

Do we still wanna keep it at 15 minutes??
What do you think?

Copy link
Contributor

@stone-z stone-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz link the issue to the PR but LGTM

@fhielpos fhielpos merged commit 90fb609 into main Jun 10, 2024
6 checks passed
@fhielpos fhielpos deleted the refactor-kyverno-replicas branch June 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants