Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cert-exporter alerting #1221

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR ensures that cert-exporter alerts page everywhere because it's deployed on all providers

Checklist

@QuentinBisson QuentinBisson self-assigned this Jun 6, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner June 6, 2024 12:40
@QuentinBisson QuentinBisson requested a review from a team June 6, 2024 12:40
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson force-pushed the fix-cert-exporter-alerting branch from 5960bc2 to b9e481e Compare June 6, 2024 12:46
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it defining that certExporter is not installed in cloud-director, capvcd and capa? I guess it is, right? 🤔

Anyway, I guess this one will page if certExporter is not actually installed and you don't have any cert_exporter_not_after metrics.

Also: don't we have a parent issue for this?

@QuentinBisson
Copy link
Contributor Author

I think it was because it was not installed in the past but it is now.

I'm reviewing alerts for multi-provider MCs but this one is a bit gray so no parent issues :(

@QuentinBisson QuentinBisson merged commit d36539e into main Jun 6, 2024
6 of 7 checks passed
@QuentinBisson QuentinBisson deleted the fix-cert-exporter-alerting branch June 6, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants