Review turtles alerts labels #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njuettner
approved these changes
Jun 6, 2024
| @@ -26,9 +26,9 @@ spec: | |||
| description: '{{`Node {{ $labels.node }} status is flapping under load.`}}' | |||
| expr: | | |||
| ( | |||
| sum(node_load15{cluster_type="management_cluster", app!="vault", role!="bastion"}) | |||
| sum(node_load15{cluster_type="management_cluster", service="node-exporter"}) | |||
There was a problem hiding this comment.
Are you sure you want to be alerted for bastions as well?
There was a problem hiding this comment.
I've checked on anteater, for the bastions the service label does not have a value; could it be different for other MCs? (if so, which are the minimal test cases? Ideally I want to avoid checking every single one for label disparities 🙈 )
QuentinBisson
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: https://github.com/giantswarm/giantswarm/issues/30934
This PR removes the labels app, node and role where possible/where it makes sense from turtles alerts.
Checklist
oncall-kaas-cloudGitHub group).