Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set type for tls secrets #1616

Merged
merged 3 commits into from
May 13, 2024
Merged

Set type for tls secrets #1616

merged 3 commits into from
May 13, 2024

Conversation

whites11
Copy link
Contributor

@whites11 whites11 commented May 9, 2024 •
edited
Loading

See https://gigantic.slack.com/archives/CDJJ17U81/p1715235121315469

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@whites11 whites11 self-assigned this May 9, 2024
@whites11 whites11 marked this pull request as ready for review May 9, 2024 10:34
@whites11 whites11 requested a review from a team as a code owner May 9, 2024 10:34
@whites11
Copy link
Contributor Author

whites11 commented May 9, 2024

@QuentinBisson I will let atlas test and merge this as I might be missing part of the big picture.

@whites11 whites11 assigned QuentinBisson and unassigned whites11 May 9, 2024
@QuentinBisson QuentinBisson merged commit 7f844f6 into master May 13, 2024
2 of 3 checks passed
@QuentinBisson QuentinBisson deleted the type-tls-secrets branch May 13, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whites11 @QuentinBisson