Add kube-proxy to the list of ignored targets #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
commented
Sep 21, 2023
| @@ -296,6 +297,10 @@ func listTargetsToIgnore(ctx context.Context, ctrlClient client.Client, cluster | |||
| if err != nil { | |||
| return nil, microerror.Mask(err) | |||
| } | |||
| bundleWithKubeProxyExporterVersion, err := semver.Parse("0.8.3") | |||
There was a problem hiding this comment.
Note that this will be released once giantswarm/observability-bundle#113 is merged
QuentinBisson
deleted the
ignore-kube-proxy-on-eks-and-latest-bundles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards monitoring of EKS clusters, we noticed that the imported EKS cluster (on snail) has kube-proxy running and we would prefer to move all EKS scraping to use ServiceMonitors instead of going through the api server proxy (related to giantswarm/roadmap#2832)
We figured with @TheoBrigitte that it is safer to have a ServiceMonitor that is not always needed than to have it being scraped from outside the cluster.
Hence this PR in relation with giantswarm/observability-bundle#113 will move the scraping of a possible kube-proxy to be done by the agent instead of externally to the cluster.
This PR is also in close relation with giantswarm/roadmap#2670
Checklist
I have:
CHANGELOG.md