Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt scrape targets to EKS clusters #1376

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Adapt scrape targets to EKS clusters #1376

merged 7 commits into from
Sep 21, 2023

Conversation

marieroque
Copy link
Contributor

@marieroque marieroque commented Sep 20, 2023 •
edited
Loading

towards giantswarm/roadmap#2811

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@marieroque marieroque requested a review from a team as a code owner September 20, 2023 14:15
@marieroque
Copy link
Contributor Author

marieroque commented Sep 20, 2023 •
edited
Loading

Need to be tested:

  • EKS snail
  • CAPI golem
  • Vintage gauss

QuentinBisson
QuentinBisson reviewed Sep 20, 2023
View reviewed changes
service/key/key.go Outdated Show resolved Hide resolved
@marieroque marieroque merged commit 45578b4 into master Sep 21, 2023
2 checks passed
@marieroque marieroque deleted the adapt-scrape-targets-to-eks branch September 21, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marieroque @QuentinBisson