Fix API Server url for Managed EKS #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
fix-api-server-url-for-eks
branch
2 times, most recently
from
cfc443c to
7357ce0
Compare
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
fix-api-server-url-for-eks
branch
from
7357ce0 to
ca27676
Compare
|
Tested on Snail, Grizzly and Gauss, fixes the EKS issue |
13 tasks
marieroque
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#2832
On Managed EKS clusters, the api-server URL populated by the CAPA provider starts with
https://and this causes issue in PMO as it cannot access the following url:https://https/F5AB99CD4973C48F8F80414C4693ED04.gr7.eu-west-2.eks.amazonaws.com:443This PR should fix it.
This will be tested on Gauss, Grizzly (CAPA and CAPA EKS) and Snail (Imported EKS)
Checklist
I have:
CHANGELOG.md