Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve agent shards calculation #1373

Merged
merged 2 commits into from
Sep 20, 2023
Merged

improve agent shards calculation #1373

merged 2 commits into from
Sep 20, 2023

Conversation

hervenicol
Copy link
Contributor

Towards https://github.com/giantswarm/giantswarm/issues/28174

Improve agent shards calculation:
we base our calculations on the max number of series for the last 6 hours, so it changes less often.

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@hervenicol hervenicol self-assigned this Sep 19, 2023
@hervenicol hervenicol marked this pull request as ready for review September 20, 2023 14:05
@hervenicol hervenicol requested a review from a team as a code owner September 20, 2023 14:05
@hervenicol
Copy link
Contributor Author

Tested on gauss with small WCs: no error in PMO, but as the clusters are rather small there's always only 1 shard.

QuentinBisson
QuentinBisson approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervenicol hervenicol merged commit 9ad013e into master Sep 20, 2023
2 checks passed
@hervenicol hervenicol deleted the nbseries_overtime branch September 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieroque marieroque marieroque approved these changes

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees

@hervenicol hervenicol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hervenicol @QuentinBisson @marieroque