Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta partial, edit links and mermaid #25

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Conversation

MarcelMue
Copy link
Contributor

What does this PR do?

This adds a meta page which is used for proper link formatting, mermaid and other convenience things.

How does it look like?

No visible change but links like "edit this page" now redirect correctly.

@MarcelMue MarcelMue requested a review from a team as a code owner March 17, 2023 12:46
@MarcelMue MarcelMue self-assigned this Mar 17, 2023
@lyind
Copy link
Contributor

lyind commented Mar 17, 2023

Interesting. This kinda fixes google/docsy#1486 "locally".

@MarcelMue
Copy link
Contributor Author

Indeed - some more stuff for mermaid in there as well though :)

@lyind
Copy link
Contributor

lyind commented Mar 17, 2023

Mermaid is cool, because it doesn't require any server-side support for rendering!

This site compares Mermaid VS PlantUML for various diagram types: https://www.dandoescode.com/blog/plantuml-vs-mermaid

I wonder if there's a converter for PlantUML to Mermaid syntax (tons of old diagrams).

Another options would be: mermaid-js/mermaid#149

Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcelMue MarcelMue merged commit 4d10223 into main Mar 17, 2023
@MarcelMue MarcelMue deleted the add-meta-partial branch March 17, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants