Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audit-logs-troubleshooting.md with Loki example #136

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

pipo02mix
Copy link
Contributor

What does this PR do?

(Please set a descriptive PR title. Use this space for additional explanations.)
Add Loki example of getting audit logs to the recipe

What does it look like?

(If this is more than a textual change, a screenshot can help in some cases to speed up the review process.)

Any background context you can provide?

(Please link public issues or summarize if not public.)

What is needed from the reviewers?

Why is this piece of content here?

(If you are adding content, please consider adding it to the main documentation at https://docs.giantswarm.io/.)

Have you maintained the front matter?

(Please bump the last_review_date in case this qualifies as a review for an entire page. Provide user_questions which should be answered in the page. Provide a meaningful description.)

@pipo02mix pipo02mix requested a review from a team October 3, 2023 13:19
@pipo02mix pipo02mix self-assigned this Oct 3, 2023
@pipo02mix pipo02mix requested a review from a team as a code owner October 3, 2023 13:19
@pipo02mix pipo02mix changed the title Update audit-logs-troubleshooting.md with Lokie example Update audit-logs-troubleshooting.md with Loki example Oct 3, 2023
@pipo02mix pipo02mix requested a review from hervenicol October 9, 2023 09:52
@pipo02mix pipo02mix requested a review from lyind October 9, 2023 10:53
@pipo02mix pipo02mix enabled auto-merge (squash) October 9, 2023 10:53
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR got forgotten. The more we wait the more this info becomes outdated 😅
Let's merge!

Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only minor improvement suggestions


## Using Loki

Today all vintage Management Clusters have Loki instance deployed with audit logs included. So we can leverage on Loki to get the logs. Future weeks we will extend Loki to vintage Workload Clusters too. Example of query:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Today all vintage Management Clusters have Loki instance deployed with audit logs included. So we can leverage on Loki to get the logs. Future weeks we will extend Loki to vintage Workload Clusters too. Example of query:
Today all vintage Management Clusters have a Loki instance deployed with audit logs included. So we can leverage Loki to get the logs. We will also roll out Loki on vintage Workload Clusters in the coming weeks. Example of query:

@pipo02mix pipo02mix merged commit 1704f10 into main Nov 30, 2023
4 of 5 checks passed
@pipo02mix pipo02mix deleted the pipo02mix-patch-2 branch November 30, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants