This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
generated from giantswarm/template-app
-
Notifications
You must be signed in to change notification settings - Fork 0
Add grafana-agent-logging-secret in the chart to store logging write credentials #21
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8107e6b
Add grafana-agent-logging-secret in the chart to store logging write …
e2f984b
EOF
2f0ea63
Fix tpl
db01263
Fix values to handle loggingSecret
253e271
Fix secret
6ff1027
Rename default secret name
7c42040
Update schema
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
helm/grafana-agent/templates/logging-credentials-secret.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{{- if .Values.loggingSecret.enabled }} | ||
apiVersion: v1 | ||
kind: Secret | ||
metadata: | ||
name: {{ .Values.loggingSecret.secretName | default "grafana-agent-secret" }} | ||
namespace: {{ .Release.Namespace }} | ||
labels: | ||
{{- include "grafana-agent.labels" . | nindent 4 }} | ||
stringData: | ||
logging-url: {{ .Values.loggingSecret.url }} | ||
logging-tenant-id: {{ .Values.loggingSecret.tenantId }} | ||
logging-username: {{ .Values.loggingSecret.username }} | ||
logging-password: {{ .Values.loggingSecret.password }} | ||
marieroque marked this conversation as resolved.
Show resolved
Hide resolved
|
||
{{- end }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of an extra secret but do not like the custom secret parameters. I would have liked to see a more generic approach that could have been proposed upstream as well like https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/prometheus/extrasecret.yaml for the secret and this to read the secret data https://grafana.com/docs/agent/latest/flow/reference/components/remote.kubernetes.secret/#example ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your idea :-)