Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm to latest version 2.39 #424

Merged
merged 8 commits into from
Dec 9, 2020
Merged

Update azurerm to latest version 2.39 #424

merged 8 commits into from
Dec 9, 2020

Conversation

corest
Copy link
Contributor

@corest corest commented Dec 9, 2020

@corest corest requested review from a team December 9, 2020 16:07
modules/azure/blob/blob.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@whites11 whites11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tested

@corest
Copy link
Contributor Author

corest commented Dec 9, 2020

Works locally, but fails in github action. Still need to debug

@corest corest merged commit 04419a1 into master Dec 9, 2020
@corest corest deleted the azurerm-2 branch December 9, 2020 18:37
@whites11
Copy link
Contributor

whites11 commented Dec 9, 2020

FYI this was a blocker for bumping azurerm terraform in the past and apparently still is: hashicorp/terraform-provider-azurerm#2489 (comment)

@corest
Copy link
Contributor Author

corest commented Dec 9, 2020

We don't have more subnets. And we need to switch to vmss and for that we need new provider version

@sanderginn
Copy link

Hi @whites11 , I see you referenced my comment. I'd like to let you know that I had overlooked a resource and the proposed fix in the thread does seem to do the job.

@whites11
Copy link
Contributor

Hi @whites11 , I see you referenced my comment. I'd like to let you know that I had overlooked a resource and the proposed fix in the thread does seem to do the job.

Thanks for letting me know @sanderginn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants